[Act] Allow Recording Checkbox Functionality

Harald Jörg haj at posteo.de
Fri Apr 26 12:54:33 CEST 2019


Hi Lee (and Act team),

Lee  writes:

> Question about the "allow_record" input field on the talk submit form - does it actually do
> anything? My testing tonight (lpw 2019 test instance, gpw 2019, tpc in Glasgow) would
> suggest either there's a bug or i'm doing it wrong (some config not set up?).
>
> It seems that the "allow_record" flag is always set to true, and even if we submit the talk
> (for the first time) with the allow_record input checkbox off it will set it to true. Upon trying
> to edit the talk to uncheck it it will not save the change.

It took some time until I got round to it: This is a bug.

The flag is "true" because that's the database default.

If you don't check the box in the form, irrelevant of whether you just
added the talk or whether you edit it, then that input parameter isn't
passed to the HTTP request at all - and as a consequence, it doesn't
make its way to the database.

I've prepared a Pull Request to fix this: https://github.com/book/Act/pull/76
-- 
Cheers,
haj


More information about the Act mailing list